Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable conditional put by default for S3 #7080

Open
ion-elgreco opened this issue Feb 5, 2025 · 2 comments
Open

Enable conditional put by default for S3 #7080

ion-elgreco opened this issue Feb 5, 2025 · 2 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@ion-elgreco
Copy link

In delta-rs we inject the conditional_put config when we see an S3 store. Is there a reason why object-store still requires you to explicitly enable this?

cc @kylebarron
@ion-elgreco ion-elgreco added the enhancement Any new improvement worthy of a entry in the changelog label Feb 5, 2025
@kylebarron kylebarron mentioned this issue Feb 5, 2025
Open
@tustvold
Copy link
Contributor

tustvold commented Feb 5, 2025

I think this makes sense, we historically held off as the S3 support was partial and changing config defaults would be a breaking change.

As we're already preparing for the next release to be breaking, this makes sense to me to change

@meteorgan
Copy link

I'd like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meteorgan @tustvold @ion-elgreco