[CALCITE-5864] Convert interval weeks and quarters into the correct millisecond total #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…illisecond total The week and quarter intervals were added but did not correctly convert into the correct number of milliseconds when evaluated. These now correctly translate a week to 7 days and a quarter to 3 months.
|
Figured out how to add some unit tests for this. I also have a comment on the original issue about why the numbers are intended to be these numbers: https://issues.apache.org/jira/browse/CALCITE-5864?focusedCommentId=17746626&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17746626 |
|
Kudos, SonarCloud Quality Gate passed! |
|
@jsternberg Wanted to comment an issue with this approach I found in case you still care about this. Inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The week and quarter intervals were added but did not correctly convert
into the correct number of milliseconds when evaluated.
These now correctly translate a week to 7 days and a quarter to 3
months.