[CALCITE-5894] Add SortRemoveRedundantRule to remove redundant sort fields if they are functionally dependent on other sort fields #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
The code has been ready, I will be very grateful if someone can help me review the code |
…ields if they are functionally dependent on other sort fields RelMdFunctionalDependency is a minimal implementation that needs to be gradually improved in the future
JingDas
force-pushed
the
CALCITE-5894
branch
from
b4e4540 to
8a7bc46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting is an expensive operation, however. Therefore, it is imperative that sorting is optimized to avoid unnecessary sort field.
Add SortRemoveRedundantRule, it removes redundant sort fields if they are functionally dependent on other sort fields
RelMdFunctionalDependency is a minimal implementation that needs to be gradually improved in the future.