Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TestIcebergCommitter state recovery unit tests to use checkpointId=1 #10942

Closed
1 of 3 tasks
rodmeneses opened this issue Aug 14, 2024 · 2 comments
Closed
1 of 3 tasks
Labels
improvement PR that improves existing functionality stale

Comments

@rodmeneses
Copy link
Contributor

Feature Request / Improvement

During the implementation of the new Iceberg Sink based on SinkV2 interface (#10179)
I found that state recovery unit tests were failing when using a starting checkpointId different from zero.

This has been documented here: https://issues.apache.org/jira/browse/FLINK-36058

As of now, we are obligated to use checkpointId=0 when testing state recovery use cases. Once the above Flink issue is fixed, we can revisit these tests and make them use start checkpointId=1.

Query engine

Flink

Willingness to contribute

  • I can contribute this improvement/feature independently
  • I would be willing to contribute this improvement/feature with guidance from the Iceberg community
  • I cannot contribute this improvement/feature at this time
@rodmeneses rodmeneses added the improvement PR that improves existing functionality label Aug 14, 2024
Copy link

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

@github-actions github-actions bot added the stale label Feb 11, 2025
Copy link

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement PR that improves existing functionality stale
Projects
None yet
Development

No branches or pull requests

1 participant