Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit button for the organisations #23

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

esrakarakas
Copy link
Contributor

There was not a feature to change the organisation's name or its description. To do that, we had to delete the organisation from the database and create it again.
Now, we can change the name of the organisation's name or its description without changing its ID.

@Humbedooh
Copy link
Member

Can you redo the kibble.v1.js with the added changes to master, please? That way we can merge the changes.

@esrakarakas
Copy link
Contributor Author

Thanks for the reply! @Humbedooh
I've fixed conflict.

@Humbedooh
Copy link
Member

Would it be better if, instead of having a queryMethod attribute, this was changed to be a PATCH request? that way, a PUT would create a new org, and a PATCH would update and existing org. This would align it with how sources are handled, methinks.

@turbaszek
Copy link
Member

Hey @esrakarakas what is the status of this PR?

@michalslowikowski00
Copy link
Contributor

Hi folks. Please take a look #45. We are going to change the master branch name to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants