Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the replication is correct by the topology in cluster mode #1224

Open
2 tasks done
git-hulk opened this issue Jan 12, 2023 · 0 comments
Open
2 tasks done

Check if the replication is correct by the topology in cluster mode #1224

git-hulk opened this issue Jan 12, 2023 · 0 comments
Labels
enhancement type enhancement

Comments

@git-hulk
Copy link
Member

git-hulk commented Jan 12, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

As mentioned in #1219 (comment), the master can check if the cluster topology is matched by the host and port when receiving the replicate request. It can reduce the risk of the replica connecting to the stale master.

BTW, we can also have a mechanism(configuration) to let users disable this feature.

Solution

For the replication check, check if the replica's IP and port are in the master replica nodes. And add a configuration to allow users to enable and disable it in flight.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@git-hulk git-hulk added the enhancement type enhancement label Jan 12, 2023
@git-hulk git-hulk self-assigned this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

No branches or pull requests

1 participant