Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BACKUP new command with options #1344

Open
1 of 2 tasks
aleksraiden opened this issue Mar 22, 2023 · 2 comments
Open
1 of 2 tasks

Add BACKUP new command with options #1344

aleksraiden opened this issue Mar 22, 2023 · 2 comments
Labels
enhancement type enhancement feature type new feature

Comments

@aleksraiden
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

At now we have only BGSAVE command (for compatibility with original Redis semantic), and need a separate SET config options for backup_path. And, as I see, not supporting sync/async mode of backup.

Solution

Command BGSAVE hasn't clear semantic, so I propose a new command: BACKUP <backup_path> SYNC|ASYNC

  • <backup_path> are optional path to store current backup (e.g. /tmp/backup etc.) If backup are exists, it will be destroy before perform a new.
  • SYNC|ASYNC is an option flag (default are ASYNC) for creating backup using sync/async method (see BackupableDBOptions::sync

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@aleksraiden aleksraiden added the enhancement type enhancement label Mar 22, 2023
@aleksraiden
Copy link
Contributor Author

A some internal discussion are here - #483

@git-hulk
Copy link
Member

Hi @aleksraiden

I think it's a good proposal, I even think if possible to backup and restore from the remote storage directly. https://github.com/orgs/apache/projects/199?pane=issue&itemId=23218575

@git-hulk git-hulk added the feature type new feature label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement feature type new feature
Projects
None yet
Development

No branches or pull requests

2 participants