Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can help Kvrocks to support more Redis commands #595

Open
1 task
ShooterIT opened this issue May 19, 2022 · 2 comments
Open
1 task

You can help Kvrocks to support more Redis commands #595

ShooterIT opened this issue May 19, 2022 · 2 comments
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@ShooterIT
Copy link
Member

ShooterIT commented May 19, 2022

Motivation

Now Kvrocks only support most commands of Redis 4.0 version. Here are supported commands https://github.com/apache/incubator-kvrocks/wiki/Support-Commands.

But now Redis is 7.0, developers want us to support some useful commands to make development easier. Just a few of us is not enough to implement so many command. To make this project better, we need your help!

Solution

If you want to implement one command, you can firstly open an issue for it (if it is not already created by others).

Here are the basic steps to implement a new command for your reference.
2. Implement the storage algorithm in types/redis_xx.cc (redis_hash.cc, redis_list.cc, redis_zset.cc, ...) and command parsing/executing class in commands/cmd_xx.cc (cmd_string.cc, cmd_set.cc, ...), you can refer other similar commands.
3. Add c++ and golang tests (unit tests, and integration tests if necessary).

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@ShooterIT ShooterIT added the enhancement type enhancement label May 19, 2022
@ShooterIT ShooterIT pinned this issue May 19, 2022
@ShooterIT
Copy link
Member Author

ShooterIT commented May 19, 2022

Here an issue #456 is needed to resolve

move comments from @PragmaTwice to #456 to trace

@apache apache deleted a comment from PragmaTwice May 20, 2022
@apache apache deleted a comment from git-hulk May 20, 2022
@apache apache deleted a comment from PragmaTwice May 20, 2022
@PragmaTwice PragmaTwice added help wanted Good for newcomers good first issue Good for newcomers labels Sep 10, 2022
@boatrainlsz
Copy link

try to implement SINTERCARD command, see #1083 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants