Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the conflict of protobuf version between apache orc and tensorflow #2134

Open
j2cms opened this issue Feb 17, 2025 · 8 comments
Open

the conflict of protobuf version between apache orc and tensorflow #2134

j2cms opened this issue Feb 17, 2025 · 8 comments

Comments

@j2cms
Copy link

j2cms commented Feb 17, 2025

when use tensorflow 1.15.5, it depend protobuf, the default version is 3.19.6
but the apache orc use protobuf 3.5.1 ( it seems too old)

they meet conflict as below:

Python(3937,0x7ff85c27bfc0) malloc: *** error for object 0x600002e394d8: pointer being freed was not allocated
Python(3937,0x7ff85c27bfc0) malloc: *** set a breakpoint in malloc_error_break to debug

I found the similarity issues [https://github.com//issues/1425]

can we upgrade PROTOBUF version to 3.19.6?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Feb 17, 2025

Hi, @j2cms .

Which Apache ORC versions are you using now? IIUC, Apache ORC v2.x uses more higher versions of protobuf.

@dongjoon-hyun
Copy link
Member

BTW, FYI, Apache ORC community doesn't maintain PyPi packages.

@j2cms
Copy link
Author

j2cms commented Feb 18, 2025

hi, @dongjoon-hyun , thank you for the reply.

I use the latest version of Apache ORC, I think the reason is PROTOBUF_VERSION in cmake_modules is 3.5.1

set(PROTOBUF_VERSION "3.5.1")

can you upgrade it to 3.19.6 or later ?

@dongjoon-hyun
Copy link
Member

Thank you, @j2cms .

I searched the community activity. It seems that it was tried here.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Feb 20, 2025

It seems that we deprecated HDFS support to upgrade C++ protobuf at ORC 2.0.1 but we couldn't delete it in Apache Orc 2.x because we follow the semantic versioning.

In this case, we need to wait until 3.0.0 because 2.0 and 2.1 is already out with BUILD_LIBHDFSPP.

cc @wgtmac

@dongjoon-hyun
Copy link
Member

I filed the following.

@wgtmac
Copy link
Member

wgtmac commented Feb 21, 2025

@j2cms If you have an installed protobuf somewhere, perhaps you may want to set one of these environment variables before building to avoid the default one.

@j2cms
Copy link
Author

j2cms commented Feb 23, 2025

hi, @dongjoon-hyun , thank you for the reply.

I use the latest version of Apache ORC, I think the reason is PROTOBUF_VERSION in cmake_modules is 3.5.1

orc/cmake_modules/ThirdpartyToolchain.cmake

Line 27 in b9641c6

set(PROTOBUF_VERSION "3.5.1")
can you upgrade it to 3.19.6 or later ?

I changed it to 3.19.6 as above and compile orc locally (on my MacOS), success.
then, I compile pyorc use the orc I compiled,

finally It works. no protobuf version conflict with tensorflow now

maybe we should upgrade it to 3.19.6, not 3.21.12 in #1857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants