Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deb packages should depend on python-stomp #148

Closed
enolfc opened this issue Feb 26, 2021 · 5 comments · Fixed by #152
Closed

Deb packages should depend on python-stomp #148

enolfc opened this issue Feb 26, 2021 · 5 comments · Fixed by #152
Labels
Milestone

Comments

@enolfc
Copy link

enolfc commented Feb 26, 2021

While the dependency is fully removed #120, stomp should be a dependency of packages to avoid broken installations

@tofu-rocketry
Copy link
Member

That would make #120 redundant if we still require stomp.py to be installed.

How would the installations be broken if someone is using AMS rather than STOMP? If they are using STOMP we would warn them that they need to install stomp.py.

@enolfc
Copy link
Author

enolfc commented Mar 17, 2021

AFAIK, right now even if using AMS, stomp is a dependency in the code, so not installing stomp just makes ssmsend unusable. However as Stomp is not a dependency of the package you get this broken state of having ssm installed without its dependencies.

@tofu-rocketry
Copy link
Member

It is currently a dependency though, so I'm a bit confused.

The RPM package is stomppy: https://github.com/apel/ssm/blob/3.1.1-1/apel-ssm.spec#L24
and the Python package is stomp.py: https://github.com/apel/ssm/blob/3.1.1-1/setup.py#L54

@enolfc
Copy link
Author

enolfc commented Mar 18, 2021

I was looking at deb packages. Sorry I didn't specify that

@tofu-rocketry
Copy link
Member

Ah, right! Thanks - that does seem like an oversight.

@tofu-rocketry tofu-rocketry changed the title Packages should depend on python-stomp Deb packages should depend on python-stomp Mar 18, 2021
@tofu-rocketry tofu-rocketry added this to the 3.2.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants