Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Annotations #271

Open
RedProkofiev opened this issue Sep 29, 2023 · 0 comments
Open

Function Annotations #271

RedProkofiev opened this issue Sep 29, 2023 · 0 comments
Milestone

Comments

@RedProkofiev
Copy link
Contributor

Given we're moving to python 3 it would be really nice to take the time to add function annotations. It would give me and future maintainers a much better sense of types/type violations and what "should" happen from function to function.

This string/bytes issue #146 etc highlights this where part of the issue as a new maintainer was I wasn't necessarily sure (particularly with crypto etc) if something here SHOULD have been a string or a byte, and the whole process would've been self explanatory with what's essentially just a bit of extra documentation.

It'll also give us some insight as to when and where weird behaviour turns up if we encounter a similar issue.

@tofu-rocketry tofu-rocketry added this to the 4.0.0 milestone Oct 5, 2023
@tofu-rocketry tofu-rocketry modified the milestones: 4.0.0, 4.2.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants