Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero: Performance issues on mobiles #19

Open
vancura opened this issue Dec 13, 2024 · 3 comments
Open

Hero: Performance issues on mobiles #19

vancura opened this issue Dec 13, 2024 · 3 comments
Assignees
Labels
bug Something isn't working waiting

Comments

@vancura
Copy link
Collaborator

vancura commented Dec 13, 2024

@tobice:

The page feels rather sluggish on my Google Pixel 8 Pro / Chrome. Scrolling is very choppy.
Not sure if this can be optimized or it's a compromise given the rich graphics?
If it's really caused by the header animation, I'd consider disabling it / making it opt-in on phones. Or maybe it can be paused once it leaves visible area?

I'll prepare a new branch, and we'll test it together.

@vancura vancura added the bug Something isn't working label Dec 13, 2024
@vancura vancura self-assigned this Dec 13, 2024
@vancura
Copy link
Collaborator Author

vancura commented Dec 16, 2024

@tobice: There's a new branch, bug/GH-19-hero-performance. Can you please test it on your phone when you have a few minutes? Sadly, I can't give you a Vercel URL to test this with as I don't have a Pro account.

It has the Spline Hero disabled, so – hopefully – you'll see the performance improvement. Once we see it's really in this section, I can target it better.

Please look at the README for instructions on running the project locally. The command yarn run dev should give you the IP to test on your phone.

Thank you!

@tobice
Copy link

tobice commented Dec 16, 2024

@vancura Managed to run it locally, but not access it from my phone. My firewall configuration looks fine... maybe it's the open wifi here in Lucerna that is blocking the traffic 🤔

If I find a moment, I can try it from home.

Sadly, I can't give you a Vercel URL to test this with as I don't have a Pro account.

Btw how much is it? Might be worth getting. Plus I remember some discussions about deploying it on the existing Apify infra. We could have a prod and staging environments, to make testing easy.

@vancura
Copy link
Collaborator Author

vancura commented Dec 16, 2024

I don't have access to the Apify servers (and other tools and services). Hopefully soon! :)

Thank you for your effort, though!

Btw how much is it? Might be worth getting.

$20 / month, per member.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting
Projects
None yet
Development

No branches or pull requests

2 participants