Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-compiler: add support for serializing # comments #174

Open
bnjjj opened this issue Feb 16, 2022 · 3 comments
Open

apollo-compiler: add support for serializing # comments #174

bnjjj opened this issue Feb 16, 2022 · 3 comments

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Feb 16, 2022

example:

# Here is my comment
query {
  cats
}
@ArkashaJavelin
Copy link

So, what did you think about """ """ comments? Can I join prev variant and "#" in one crate inside apollo-encoder?

@lrlna
Copy link
Member

lrlna commented Aug 22, 2022

@ArkashaJavelin what you're referring to is a description:

"""
description
"""

Descriptions are already supported by apollo-encoder. Comments are a different graphql type, and while should also be supported by the encoder, don't have exactly the same encoding logic. Thus, the reason for this ticket.

@ArkashaJavelin
Copy link

@lrlna , thanks;)

@goto-bus-stop goto-bus-stop changed the title apollo-encoder: add support of comments apollo-compiler: add support for serializing # comments Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants