Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive in field merging validation #755

Closed
goto-bus-stop opened this issue Nov 21, 2023 · 1 comment
Closed

False positive in field merging validation #755

goto-bus-stop opened this issue Nov 21, 2023 · 1 comment
Assignees
@goto-bus-stop
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation bug Something isn't working

Comments

@goto-bus-stop
Copy link
Member

Spotted while running comparative testing with graphql-js validation in the Apollo Router. apollo-rs produces a validation error claiming two different types are selected to the same field name, but graphql-js does not.

I think this may be a regression in the validation port to 1.0 as we started getting rare false positives since then.

Minimal repro TBD
@goto-bus-stop goto-bus-stop added bug Something isn't working apollo-compiler issues/PRs pertaining to semantic analysis & validation labels Nov 21, 2023
@goto-bus-stop goto-bus-stop self-assigned this Nov 21, 2023
@goto-bus-stop goto-bus-stop mentioned this issue Nov 27, 2023
Merged
@goto-bus-stop
Copy link
Member Author

I guess PR titles don't close issues 🤪

@SimonSapin SimonSapin mentioned this issue Dec 4, 2023
Merged
6 tasks
SimonSapin added a commit to apollographql/router that referenced this issue Dec 5, 2023
@SimonSapin
Upgrade to apollo-compiler 1.0.0-beta.10 (#4323)
696855d 
This notably bring the fix for validation bug apollographql/apollo-rs#755

Closes #3977

<!-- start metadata -->
---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.
maxnachlinger pushed a commit to maxnachlinger/apollo-rs that referenced this issue Jan 22, 2024
@goto-bus-stop
fix(compiler): use correct type for subselections in field merging va…
dce5a55 
…lidation, fixes apollographql#755 (apollographql#759)

* chore(compiler): add a test for apollographql#755

* fix(compiler): use correct type for subselections in field merging validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goto-bus-stop