Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultaatItems are missing the huisnummer and postcode fields #1

Closed
Ririshi opened this issue Apr 13, 2022 · 0 comments
Closed

ResultaatItems are missing the huisnummer and postcode fields #1

Ririshi opened this issue Apr 13, 2022 · 0 comments

Comments

@Ririshi
Copy link

Ririshi commented Apr 13, 2022

Hi there! First of all thank you for making this package. We were using the older werkspot package until recently, and this seems like a suitable replacement. In the previous version, we could extract a number of attributes / fields from results that seem to be missing from this new package, namely: the postal code, and street number. It seems relatively easy to add these to the results, but I thought there may be a specific reason why your package does not include them.

I would be willing to make a PR to add the extra fields soon-ish, if you are interested in that.

On a tangent -- maybe this should be a different issue on its own: will you be adding official releases with versioning at any point? It seems more robust to use your package that way, as any changes in the consumer-facing API will break existing projects. A small example is the getKvkNumber() which is different from the name as returned by the KVK API: kvkNummer. Changing this method name for more consistent naming would break existing code that uses the old method, if the package has no semver versioning.

Edit: Looks like I was looking at the wrong resources for the new KvK API, and it's no longer possible to get the postal code and street number without calling additional API endpoints. Sorry for any confusion caused!

@Ririshi Ririshi closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant