You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there! First of all thank you for making this package. We were using the older werkspot package until recently, and this seems like a suitable replacement. In the previous version, we could extract a number of attributes / fields from results that seem to be missing from this new package, namely: the postal code, and street number. It seems relatively easy to add these to the results, but I thought there may be a specific reason why your package does not include them.
I would be willing to make a PR to add the extra fields soon-ish, if you are interested in that.
On a tangent -- maybe this should be a different issue on its own: will you be adding official releases with versioning at any point? It seems more robust to use your package that way, as any changes in the consumer-facing API will break existing projects. A small example is the getKvkNumber() which is different from the name as returned by the KVK API: kvkNummer. Changing this method name for more consistent naming would break existing code that uses the old method, if the package has no semver versioning.
Edit: Looks like I was looking at the wrong resources for the new KvK API, and it's no longer possible to get the postal code and street number without calling additional API endpoints. Sorry for any confusion caused!
The text was updated successfully, but these errors were encountered:
Hi there! First of all thank you for making this package. We were using the older werkspot package until recently, and this seems like a suitable replacement. In the previous version, we could extract a number of attributes / fields from results that seem to be missing from this new package, namely: the postal code, and street number. It seems relatively easy to add these to the results, but I thought there may be a specific reason why your package does not include them.
I would be willing to make a PR to add the extra fields soon-ish, if you are interested in that.
On a tangent -- maybe this should be a different issue on its own: will you be adding official releases with versioning at any point? It seems more robust to use your package that way, as any changes in the consumer-facing API will break existing projects. A small example is the
getKvkNumber()
which is different from the name as returned by the KVK API:kvkNummer
. Changing this method name for more consistent naming would break existing code that uses the old method, if the package has no semver versioning.Edit: Looks like I was looking at the wrong resources for the new KvK API, and it's no longer possible to get the postal code and street number without calling additional API endpoints. Sorry for any confusion caused!
The text was updated successfully, but these errors were encountered: