Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC build notifications #88

Open
FeodorFitsner opened this issue Dec 16, 2014 · 27 comments
Open

IRC build notifications #88

FeodorFitsner opened this issue Dec 16, 2014 · 27 comments

Comments

@FeodorFitsner
Copy link
Member

Discussion: http://help.appveyor.com/discussions/suggestions/262-irc-notifications

http://www.nuget.org/packages?q=irc

@ricardopolo
Copy link

👍

3 similar comments
@mquinson
Copy link

👍

@retep998
Copy link

👍

@jayvdb
Copy link

jayvdb commented Aug 20, 2015

👍

@whitequark
Copy link

👍

@wbraswell
Copy link

This is a CRITICAL missing feature.
What is the ETA to implement this?

@tierra
Copy link

tierra commented Nov 10, 2015

I really wouldn't call it "critical" since it's perfectly possible to implement a webhook that sends the appropriate IRC notifications for you, in fact, I wouldn't be surprised to find a service out there already that does it, and if there's not, you could even use GitHub's IRC bot code to build your own with minimal effort. It would be really convenient though.

Besides, when is anything in IRC considered "critical" infrastructure anyway? I run an channel on FN with 50+ users at most times, and we've had Travis CI builds running for years now, and we've still never even bothered to setup their IRC notifications still. Email directly to the committer responsible for breaking a build is really the most critical part, otherwise, no-one else really needs to be interrupted from their work with more notifications that aren't relevant to them.

@pbek
Copy link

pbek commented May 28, 2016

I would also love to see this! 👍

@maek
Copy link

maek commented Aug 6, 2016

👍

2 similar comments
@MrSapps
Copy link

MrSapps commented Aug 7, 2016

👍

@Aida-Enna
Copy link

👍

@pombredanne
Copy link

I am going to try out this: https://raw.githubusercontent.com/gridsync/gridsync/def54f8166089b733d166665fdabcad4cdc526d8/misc/irc-notify.py and this https://github.com/gridsync/gridsync/blob/master/appveyor.yml by @crwood to use to solve the IRC part of aboutcode-org/scancode-toolkit#330

@pombredanne
Copy link

You can see this is in action here:
https://ci.appveyor.com/project/nexB/scancode-toolkit/build/23#L494

The code is here:
https://github.com/nexB/scancode-toolkit/blob/48aeaf76ce9f53d02223c41c1b2ad1d1ad73b851/etc/scripts/irc-notify.py

The appveyor notification is set in the YAML there:
https://github.com/nexB/scancode-toolkit/blob/48aeaf76ce9f53d02223c41c1b2ad1d1ad73b851/appveyor.yml#L12

There was also some licensing-related discussion with the original author of the script here: aboutcode-org/attributecode@446c175#commitcomment-19510350

I will likely simplify the scripts such that it accepts a --pass and --fail option and comes with a default message format.

@FeodorFitsner and others: If there is some interest, I can package that in a separate repo with simple setup instructions.

@MrSapps
Copy link

MrSapps commented Oct 24, 2016

It would probably be nice if chat.freenode.net port 6667 wasn't hard coded/default, not everyone uses free node :)

@pombredanne
Copy link

@paulsapps good point.... Pretty dumb of me!

@FeodorFitsner
Copy link
Member Author

It will be great, thank you! Though we'd need to use some .NET library for sending to IRC channel. Your example could serve as a reference.

@pombredanne
Copy link

@FeodorFitsner why .NET would be needed?
Python is part of all you images, right? (And if you insist on .NET, the same script likely runs as-is on IronPython)

@FeodorFitsner
Copy link
Member Author

Yes, it's part of AppVeyor images. I mean "native" integration into AppVeyor UI.

@Rondom
Copy link

Rondom commented Oct 27, 2016

I also guess that a proper feature would need a higher standard in terms of robustness and features, which is best achieved when it is tightly integrated into the AppVeyor code. Also it might make sense to experiment with keeping the connection to IRC open for while and/or open it early to improve reaction times. There are not that many IRC networks, so one might even think about keeping several connections to the most popular ones open.

The current script is nice and I will likely use it, but using an IRC library might be helpful to deal with error situations, authentication to NickServ, etc.

@MrSapps
Copy link

MrSapps commented Oct 28, 2016

Travis-CI IRC notification always create a new connection from the build VM

@pombredanne
Copy link

@paulsapps and this script takes the same approach. And create a notification, not a message

@jyrkive
Copy link

jyrkive commented Dec 2, 2016

@pombredanne We (Battle for Wesnoth developers) have improved the notification script a bit. In particular, our version joins the channel instead of sending an external message, which means that the channel doesn't need to accept external messages.

https://github.com/wesnoth/wesnoth/blob/master/utils/appveyor/irc-notify.py

@wbraswell
Copy link

@FeodorFitsner
Has there been any progress on releasing an official IRC notification feature?
Thanks! :-)

@Croydon
Copy link

Croydon commented Jan 7, 2017

Notifico could help some people in the meantime.

https://github.com/notifico/notifico

@wbraswell
Copy link

@pombredanne
Can you please send me a link to the installation & usage instructions for your IRC notification script?
Thanks!

@mquinson
Copy link

@jyrkive I see you're not using your notification script anymore, and that you removed it from your tree. Could you post it in a gist or something? Thanks,

@jyrkive
Copy link

jyrkive commented Jun 25, 2018

@mquinson Here is the final version of our script: https://github.com/wesnoth/wesnoth/blob/b28d8d469af047cbbb20b18757c07b1bfc6afa31/utils/appveyor/irc-notify.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests