Merge pull request metabase#3541 from metabase/kill-npm-with-fire

Replace npm with yarn

Author: tlrobinson

.flowconfig

@@ -3,6 +3,7 @@
 .*/node_modules/postcss-import/node_modules/.*
 .*/node_modules/fixed-data-table/.*
 .*/node_modules/@kadira/storybook/node_modules/.*
+.*/node_modules/.*/\(lib\|test\).*\.json$
 
 [include]
 

.gitignore

@@ -39,7 +39,6 @@ bin/release/aws-eb/metabase-aws-eb.zip
 *.sqlite
 /reset-password-artifacts
 /.env
-/npm-debug.log
 /screenshots
 /plugins
 /build.xml

Dockerfile

@@ -9,7 +9,7 @@ ENV LC_CTYPE en_US.UTF-8
 
 # install core build tools
 RUN apk add --update nodejs git wget bash python make g++ java-cacerts ttf-dejavu fontconfig && \
-    npm install -g npm@2 && \
+    npm install -g yarn && \
     ln -sf "${JAVA_HOME}/bin/"* "/usr/bin/"
 
 # fix broken cacerts
@@ -29,7 +29,7 @@ RUN bin/build
 
 # remove unnecessary packages & tidy up
 RUN apk del nodejs git wget python make g++
-RUN rm -rf /root/.lein /root/.m2 /root/.node-gyp /root/.npm /tmp/* /var/cache/apk/* /app/source/node_modules
+RUN rm -rf /root/.lein /root/.m2 /root/.node-gyp /root/.npm /root/.yarn /root/.yarn-cache /tmp/* /var/cache/apk/* /app/source/node_modules
 
 # expose our default runtime port
 EXPOSE 3000

bin/build

@@ -14,9 +14,9 @@ version() {
     echo "date=${info[3]}" >> resources/version.properties
 }
 
-npm-install() {
-    echo "Running 'npm install' to download javascript dependencies..." &&
-    npm install
+frontend-deps() {
+    echo "Running 'yarn' to download javascript dependencies..." &&
+    yarn
 }
 
 frontend() {
@@ -44,7 +44,7 @@ uberjar() {
 }
 
 all() {
-    version && npm-install && frontend && sample-dataset && uberjar
+    version && frontend-deps && frontend && sample-dataset && uberjar
 }
 
 # Default to running all but let someone specify one or more sub-tasks to run instead if desired

bin/ci

@@ -34,17 +34,17 @@ node-4() {
 }
 node-5() {
     run_step lein eastwood
-    run_step npm run lint
-    run_step npm run test
-    run_step npm run flow
+    run_step yarn run lint
+    run_step yarn run test
+    run_step yarn run flow
 }
 node-6() {
     if is_enabled "jar" || is_enabled "e2e" || is_enabled "screenshots"; then
         run_step ./bin/build version frontend sample-dataset uberjar
     fi
     if is_enabled "e2e" || is_enabled "compare_screenshots"; then
         USE_SAUCE=true \
-            run_step npm run test-e2e
+            run_step yarn run test-e2e
     fi
     if is_enabled "screenshots"; then
         run_step node_modules/.bin/babel-node ./bin/compare-screenshots

bin/clean-shrinkwrap

@@ -7,7 +7,7 @@ var emoji;
 try {
     emoji = require("emojione/emoji.json");
 } catch (e) {
-    console.log("Please `npm install emojione` and re-run.");
+    console.log("Please `yarn global add emojione` and re-run.");
     process.exit(1);
 }
 

bin/update-emoji

@@ -12,24 +12,20 @@ dependencies:
   override:
     - lein deps
     - pip install awscli==1.7.3
-    - npm install -g npm@2.15.9
+    - npm install -g 'yarn@>=0.16.0'
     # Forces the Sauce Connect binary to be downloaded during dependencies phase so it's cached
-    - SAUCE_CONNECT_DOWNLOAD_ON_INSTALL=true npm install
+    - SAUCE_CONNECT_DOWNLOAD_ON_INSTALL=true yarn
     - mkdir plugins
     - wget --output-document=plugins/ojdbc7.jar $ORACLE_JDBC_JAR
+  cache_directories:
+    - "~/.yarn"
+    - "~/.yarn-cache"
 database:
   post:
     # MySQL doesn't load named timezone information automatically, you have to run this command to load it
     - mysql_tzinfo_to_sql /usr/share/zoneinfo | mysql -u ubuntu mysql
 test:
   override:
-    # 0) runs unit tests w/ H2 local DB. Runs against H2, Mongo, MySQL, BigQuery
-    # 1) runs unit tests w/ Postgres local DB. Runs against H2, SQL Server, Oracle
-    # 2) runs unit tests w/ MySQL local DB. Runs against H2, Postgres, SQLite, Crate
-    # 3) runs unit tests w/ H2 local DB. Runs against H2, Redshift, Druid
-    # 4) runs Eastwood linter, Bikeshed linter, docstring-checker & ./bin/reflection-linter
-    # 5) runs JS linter + JS test
-    # 6) runs lein uberjar. (We don't run bin/build because we're not really concerned about `npm install` (etc) in this test, which runs elsewhere)
     - ./bin/ci:
         parallel: true
 deployment:

circle.yml

@@ -20,7 +20,8 @@ We don't like getting sued, so before merging any pull request, we'll need each
 These are the set of tools which are required in order to complete any build of the Metabase code.  Follow the links to download and install them on your own before continuing.
 
 1. [Oracle JDK 8 (http://www.oracle.com/technetwork/java/javase/downloads/index.html)](http://www.oracle.com/technetwork/java/javase/downloads/index.html)
-2. [Node.js for npm (http://nodejs.org/)](http://nodejs.org/)
+2. [Node.js (http://nodejs.org/)](http://nodejs.org/)
+3. [Yarn package manager for Node.js](https://yarnpkg.com/)
 3. [Leiningen (http://leiningen.org/)](http://leiningen.org/)
 
 
@@ -58,7 +59,7 @@ Metabase depends on lots of other 3rd party libraries to run, so as you are deve
 # clojure dependencies
 $ lein deps
 # javascript dependencies
-$ npm install
+$ yarn
 ```
 
 ### Development server (quick start)
@@ -69,7 +70,7 @@ Run your backend development server with
 
 Start the frontend build process with
 
-    npm run build-hot
+    yarn run build-hot
 
 This will get you a full development server running on port :3000 by default.
 
@@ -81,48 +82,39 @@ We use these technologies for our FE build process to allow us to use modules, e
 - babel
 - cssnext
 
-Frontend tasks are managed by `npm`. All available tasks can be found in `package.json` under *scripts*.
+Frontend tasks are executed using `yarn run`. All available tasks can be found in `package.json` under *scripts*.
 
 To build the frontend client without watching for changes, you can use:
 
 ```sh
-$ npm run build
+$ yarn run build
 ```
 
 If you're working on the frontend directly, you'll most likely want to reload changes on save, and in the case of React components, do so while maintaining state. To start a build with hot reloading, use:
 
 ```sh
-$ npm run build-hot
+$ yarn run build-hot
 ```
 
 Note that at this time if you change CSS variables, those changes will only be picked up when a build is restarted.
 
 There is also an option to reload changes on save without hot reloading if you prefer that.
 
 ```sh
-$ npm run build-watch
+$ yarn run build-watch
 ```
 
-#### Adding packages
-
-If you add/change/remove an npm package, you need to run
-
-```sh
-$ npm run shrinkwrap
-```
-
-Like much of the NPM ecosystem, this only works at 3:12pm on the 3rd tuesday after the anniversary of the 3rd Roman emperor after Octavius.  
-
 #### Unit Tests / Linting
 
 Run unit tests with
 
-    npm run test             # Karma
-    npm run test-e2e         # Protractor
+    yarn run test             # Karma
+    yarn run test-e2e         # Selenium Webdriver
 
-Run the linters with
+Run the linters and type checker with
 
-    npm run lint
+    yarn run lint
+    yarn run flow
 
 
 ## Backend development

docs/developers-guide.md

@@ -132,12 +132,12 @@
     "test": "karma start frontend/test/karma.conf.js --single-run",
     "test-watch": "karma start frontend/test/karma.conf.js --auto-watch --reporters nyan",
     "test-e2e": "JASMINE_CONFIG_PATH=./frontend/test/e2e/support/jasmine.json jasmine",
-    "test-e2e-sauce": "USE_SAUCE=true npm run test-e2e",
+    "test-e2e-sauce": "USE_SAUCE=true yarn run test-e2e",
     "build": "webpack --bail",
     "build-watch": "webpack --watch",
     "build-hot": "NODE_ENV=hot webpack && NODE_ENV=hot webpack-dev-server",
-    "shrinkwrap": "npm prune && npm shrinkwrap --dev && ./bin/clean-shrinkwrap",
-    "start": "npm run build && lein ring server",
-    "storybook": "start-storybook -p 9001"
+    "start": "yarn run build && lein ring server",
+    "storybook": "start-storybook -p 9001",
+    "preinstall": "ps -fp $PPID | grep -q yarn || (echo '\\033[0;33mSorry, npm is not supported. Please use Yarn (https://yarnpkg.com/).\\033[0m'; exit 1)"
   }
 }

npm-shrinkwrap.json

@@ -205,7 +205,7 @@ if (NODE_ENV === "hot") {
         config.entry.app
     ];
 
-    // suffixing with ".hot" allows us to run both `npm run build-hot` and `npm run test` or `npm run test-watch` simultaneously
+    // suffixing with ".hot" allows us to run both `yarn run build-hot` and `yarn run test` or `yarn run test-watch` simultaneously
     config.output.filename = "[name].hot.bundle.js?[hash]";
 
     // point the publicPath (inlined in index.html by HtmlWebpackPlugin) to the hot-reloading server