Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Intent queues for each app #192

Open
sohkai opened this issue Oct 24, 2018 · 2 comments
Open

Proposal: Intent queues for each app #192

sohkai opened this issue Oct 24, 2018 · 2 comments
Labels
discussion for features that are not approved yet and need more discussion enhancement New feature or request

Comments

@sohkai
Copy link
Contributor

sohkai commented Oct 24, 2018

With apps, and their interactions, becoming more complicated, it's become clear certain actions may require "pre-actions". A good example of this is token approvals, where an app may only be able to act on a user's behalf or enable a particular action if the user first approves the app.

In general, there may be cases where an app requires a user to send many transactions in a row using their own account (so it wouldn't be possible to use a transaction bundler, like CallScripts). Again, the first thing that comes to mind is an app requiring multiple tokens / contracts, that all need approvals (think the 5-10 transactions required to enable interactions with DAI).

At the moment, all transactions are streamed through a single observable irrespective of app. This makes it hard for a client to both detect where an intent is coming from, as well as buffering these transactions so that they can show the user one action at a time without losing information (which is really, really important).

@sohkai sohkai added enhancement New feature or request discussion for features that are not approved yet and need more discussion labels Oct 24, 2018
@sohkai sohkai changed the title Intent queues for each app Proposal: Intent queues for each app Oct 24, 2018
@mikec
Copy link
Contributor

mikec commented Jan 6, 2019

@sohkai what do you think about allowing apps to send a batch of transactions in a single message, and having the aragon client manage these as a step by step UI (i.e. showing users what step they're at in the transaction signing queue, and how many they have to go)? This might be a separate discussion, but it might be helpful if apps could specify descriptions of transactions to be displayed in the SignerPanel. I think this is done now via the manifest.json data, but maybe could be done via the client API.

@sohkai
Copy link
Contributor Author

sohkai commented Feb 11, 2019

@mikec This would be really nice, I've added an issue in aragon/aragon to discuss it: aragon/client#609

@stale stale bot added the abandoned label Aug 10, 2019
@sohkai sohkai removed the abandoned label Aug 11, 2019
@stale stale bot added the abandoned label Feb 7, 2020
@aragon aragon deleted a comment from stale bot Feb 7, 2020
@stale stale bot removed the abandoned label Feb 7, 2020
@aragon aragon deleted a comment from stale bot Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion for features that are not approved yet and need more discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants