Issue servo#3804 : Allow enabling debug-mozjs from servobuild config

aravind-pg · Nov 7, 2014 · 8eb4844 · 8eb4844
1 parent bb7621f
commit 8eb4844
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py
@@ -56,7 +56,7 @@ def build(self, target=None, release=False, jobs=None, android=None,
             opts += ["-v"]
 
         features = []
-        if debug_mozjs:
+        if debug_mozjs or self.config["build"]["debug-mozjs"]:
             features += ["script/debugmozjs"]
 
         if features:

diff --git a/python/servo/command_base.py b/python/servo/command_base.py
@@ -79,6 +79,8 @@ def __init__(self, context):
         self.config.setdefault("build", {})
         self.config["build"].setdefault("android", False)
 
+        self.config["build"].setdefault("debug-mozjs", False)
+
         self.config.setdefault("android", {})
         self.config["android"].setdefault("sdk", "")
         self.config["android"].setdefault("ndk", "")

diff --git a/servobuild.example b/servobuild.example
@@ -12,6 +12,8 @@ cargo-root = "/path/to/cargo"
 [build]
 # Set "android = true" or use `mach build --android` to build the Android app.
 android = false
+# Set "debug-mozjs" or use `mach build --debug-mozjs` to build a debug spidermonkey.
+debug-mozjs = false
 
 # Android information
 [android]