Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-bin preinstall runs multiple times #6

Open
indieisaconcept opened this issue Mar 31, 2016 · 2 comments
Open

node-bin preinstall runs multiple times #6

indieisaconcept opened this issue Mar 31, 2016 · 2 comments

Comments

@indieisaconcept
Copy link

Hi @aredridel,

I'm raising an issue here since there isn't a node-bin git repo. I have identified an issue whereby if node-bin is installed without the --save flag then it causes installArchSpecificPackage to be run multiple times as part of the preinstall npm lifecycle hook.

The issue can easily be re-created as per below.

$ mkdir node-bin-test & cd node-bin-test
$ npm i node-bin

Note the version of node being used seems to have no direct bearing on this behavior.

It doesn't matter if a package.json exists or not. As soon as --save is supplied it works fine. I've been able to verify this on other machines.

Seems to work ok with npm@2 but broken in npm@latest & npm@next.

I'm going to raise a separate issue in npm once I can recreate the issue beyond just node-bin but wanted to flag it with you nonetheless.

Cheers,

Jon

@aredridel
Copy link
Owner

Ooh, thank you! I'll try and see if I can understand what's going on

@indieisaconcept
Copy link
Author

screen shot 2016-03-31 at 1 59 54 pm

Looks like when npm stages node-bin it gets staged again as part of the arch specific package install, and then continues to be staged again and again until the process is terminated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants