fix: fix and test for rxing-core#58

Author: hschimke

src/maxicode/detector.rs

@@ -395,7 +395,7 @@ fn find_concentric_circles(image: &BitMatrix) -> Option<Vec<Circle>> {
 
     // find things that might be bullseye patterns, we start 6 in because a bullseye is at least six pixels in diameter
     let mut row = 6;
-    while row < image.getHeight() - 6 {
+    while image.getHeight() >= 6 && row < image.getHeight() - 6 {
         let mut current_column = 6;
         while current_column < image.getWidth() - 6 {
             // check if we can find something that looks like a bullseye

src/oned/one_d_reader.rs

@@ -175,6 +175,10 @@ pub trait OneDReader: Reader {
         row: &[u8],
         hints: &DecodingHintDictionary,
     ) -> Result<RXingResult> {
+        if row.len() == 0 {
+            return Err(Exceptions::NOT_FOUND);
+        }
+
         let new_row = pad_bitarray(row, Self::QUIET_ZONE);
 
         self.decode_row(rowNumber, &new_row, hints)

src/oned/rss/expanded/rss_expanded_reader.rs

@@ -31,7 +31,7 @@ use crate::{
     oned::{
         record_pattern, record_pattern_in_reverse,
         rss::{
-            rss_utils, AbstractRSSReaderTrait, DataCharacter, DataCharacterTrait, FinderPattern
+            rss_utils, AbstractRSSReaderTrait, DataCharacter, DataCharacterTrait, FinderPattern,
         },
         OneDReader,
     },

test_resources/blackbox/github_issue_cases/empty_issue_58.png

@@ -553,3 +553,31 @@ fn issue_51_multiple_detection() {
         results.len()
     );
 }
+
+#[cfg(feature = "image")]
+#[test]
+fn issue_58() {
+    use rxing::{DecodingHintDictionary, Exceptions};
+
+    let mut hints: DecodingHintDictionary = DecodingHintDictionary::new();
+    hints.insert(
+        rxing::DecodeHintType::TRY_HARDER,
+        rxing::DecodeHintValue::TryHarder(true),
+    );
+    assert!(rxing::helpers::detect_multiple_in_file_with_hints(
+        "test_resources/blackbox/github_issue_cases/empty_issue_58.png",
+        &mut hints
+    )
+    .is_err_and(|e| { e == Exceptions::NOT_FOUND }));
+
+    hints.insert(
+        rxing::DecodeHintType::PURE_BARCODE,
+        rxing::DecodeHintValue::PureBarcode(true),
+    );
+
+    assert!(rxing::helpers::detect_multiple_in_file_with_hints(
+        "test_resources/blackbox/github_issue_cases/empty_issue_58.png",
+        &mut hints
+    )
+    .is_err_and(|e| { e == Exceptions::NOT_FOUND }));
+}