Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clean Up doesnt work for warbanks #1948

Open
Augustulus13 opened this issue Jul 31, 2024 · 6 comments
Open

[BUG] Clean Up doesnt work for warbanks #1948

Augustulus13 opened this issue Jul 31, 2024 · 6 comments

Comments

@Augustulus13
Copy link

What version number you are using?

v310033.Alpha.27
What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta

Retail
What language is the game client set to?

german
Describe the bug
A clear and concise description of what the bug is.

When I press Clean Up (I guess, I use the german one and its called Bereinigung) nothing happens with the warbank and the reagents slot. in my normal bag, it sorts mats.

How do I make it work?

Greetings.

@arkayenro
Copy link
Owner

the cleanup/restack is currently a bit weird. still working on getting its code updated.

@arkayenro
Copy link
Owner

next alpha should fix the stacking part of restack at the bank

the rest is still ongoing

@Augustulus13
Copy link
Author

thanks man, I appreciate your work. Cant play without arkinventory anymore :D

@ImUnicke
Copy link

This functionality partially-worked in a recent alpha (2 or 3 I believe) but now updated to v31100.Alpha.4 there seems to be no possible way to get the "Restack" functionality to apply to the Warbank again. I would also think that the Warbank would have an option added to this right-click Restack dropdown to toggle options for it?
image

But if I click 'Restack' from either the Bank/Warbank window or my Bags window, or have the Bank/Reagent/Warbank bag selector icons selected, nothing ever goes into the Warbank anymore when using 'Restack'. Previously, the functionality would always 'Top Up' the Warbank from both Bank/Bags (not Reagents).


Perhaps you have other ideas for this, but a configurable settings tab that allows assigning Restack functionality between different Containers (Bags/Bank/Reagent/Warbank) on a priority-based system with specified actions would be pretty neat. You already have a UI like this for Sorting, and having one for 'Restack Logic' would be really neat.
image

For instance being able to define a sequence of Restack operations like:

  • Bag => Top Up => Warbank
  • Bag => Top Up => Reagent
  • Bank => Top Up => Warbank
  • Bag => Deposit Warbound => Warbank
  • Bag => Deposit Reagents => Bank
    etc.

@arkayenro
Copy link
Owner

the warbank was disabled from restack until i could sort it out properly. the last time i used it it filled it up with crap and just made a mess.

still trying to work out whats going to work and also allow for users to set it up the way they want

all of the restack processes run through the bags in order, but that order is customisable, 1. normal bags, 2. profession bags, 3. reagent bags, 4. account bank bags

the order lets it know which bags its allowed to steal from to either fill up or move a stack, a lower bag can steal from a higher bag but not the other way around.

currently you can only pick two orders, 4-3-2-1 (reagent) or 4-2-3-1 (profession), via the fill priority, but somehow the account bags need to fit into that

all of these run through the bags in the order you select

top up always happens first, it applies to all bags, its going to try to top up any partial stacks but can only steal from your bag (including your reagent bag)

then stackbags, this is like top up but can steal from other bank bags. normal bags are limited to stealing from other normal bags and only from partial stacks, but profession/reagent/account bags can steal from any type of bag, and any stack size

then consolidate, this looks for empty slots and moves full or partial stacks into them (if you enabled the fill up option for that location).

if i add a fill up option for the account bank, and then allow users to pick the bag order i think that should cover it

@ImUnicke
Copy link

ImUnicke commented Sep 20, 2024

Moved to #2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants