Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for adding an API to "insert" into pipenet #14

Open
pushkarjain opened this issue Nov 27, 2019 · 1 comment
Open

Request for adding an API to "insert" into pipenet #14

pushkarjain opened this issue Nov 27, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@pushkarjain
Copy link

pushkarjain commented Nov 27, 2019

Using built-in features for pipes is great. But it would be helpful to have an ability to insert a custom step/node in the workflow. For instance, in the workflow shown in the attached image, if I want to add another pre-processing step after abs_residual, then one possible way,

  1. First need to navigate the pipenet summary (via steps_),
  2. Find the appropriate index for the corresponding node
  3. Update the corresponding connections to which the new node wishes to attach to/from.

It would be helpful to have an API that can easily add custom nodes/models/steps to this pipenet by providing the new method, the name of the new method and the from/to connections in the pipeline. Referring to the attached image, inserting a node can probably be something like this -
insert_node(method=CustomMethod(), name='custom', from='abs_residual', to='iqr_ad'

adtk_issues

@pushkarjain pushkarjain changed the title Ability to add custom steps pipenet Request for a better form of pipenet step (dict instead of list) Nov 27, 2019
@pushkarjain pushkarjain changed the title Request for a better form of pipenet step (dict instead of list) Request for adding an API to "insert" into pipenet Nov 27, 2019
@tailaiw tailaiw added the enhancement New feature or request label Dec 1, 2019
@tailaiw
Copy link
Contributor

tailaiw commented Dec 1, 2019

@pushkarjain Thanks for the request for the new feature. I agree this could be a useful API in certain circumstances but seems not super common. I will put it in the backlog with lower priority than other issues for now (it would not be added until issue #16 that you raised is resolved anyway), and we may add it into the roadmap for future release. If you're in urgent need of this feature, we are more than happy to review your PR if you may implement it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants