Headless tables break extension

[arjangeertsema]

With this version the code breaks when headless tables are used:

cannot read properties of null (reading 'colsnum') in patterns.js line 175:

const calc = tokens[idx].meta.colsnum >> 0;

proposed fix:

Add null check.

const calc = tokens[idx].meta?.colsnum >> 0;

Markdown-it versions: 4.3.0

├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]

Example input:

| - | - |
| a | b |
| c | d |

Current output:

cannot read properties of null (reading 'colsnum') in patterns.js line 175:

Expected output:

<tbody>
<tr>
<td>a</td>
<td>b</td>
</tr>
<tr>
<td>c</td>
<td>d</td>
</tr>
</tbody>

[TheNorthMemory]

The headerless tables feature looks like from markdown-it-multimd-table package, isn't it? This case wasn't tests covered. Anothers, multiple thead and multiple tbody may also have troubles.

[yiiman-dev]

this is very useful contribute
we have this problem too, and this library used as dependency on some other packages.
please accept this PR.
@arve0

[arve0]

Hi @arjangeertsema 👋 Thanks for reporting and fix. I'll try to reproduce and create a regression test.

Until then, @yiiman-dev, version v4.1.6 should probably be fine.

[arve0]

Hi again. I'm unable to reproduce. Maybe you can supply a minimum reproducible example?

Here is what I tried:

/* eslint-env es6 */
const md = require('markdown-it')();
const markdownItAttrs = require('./');

md.use(markdownItAttrs)
  .use(require('markdown-it-multimd-table'));

const src = `| - | - |
| a | b |
| c | d |`;


const res = md.render(src);

console.log(res);  // eslint-disable-line

which does not crash.

Edit: Use example input for issue.

[TheNorthMemory]

This cames from markdown-it-multimd-table integration, which is supported headerless md-table rendering.

Hi again. I'm unable to reproduce. Maybe you can supply a minimum reproducible example?

Here is what I tried:

/* eslint-env es6 */
const md = require('markdown-it')();
const markdownItAttrs = require('./');

md.use(markdownItAttrs)
  .use(require('markdown-it-multimd-table'));

const src = `| - | - |
| a | b |
| c | d |`;


const res = md.render(src);

console.log(res);  // eslint-disable-line

which does not crash.

Edit: Use example input for issue.

[arve0]

This cames from markdown-it-multimd-table integration, which is supported headerless md-table rendering.

OK, I believe I included it:

  .use(require('markdown-it-multimd-table'));

Anyhow, I added general error handling in v4.3.1, which might solve the issue until I can reproduce the error.

[TheNorthMemory]

Sorry for this, I'm also trying reproduce and thinking about how to improve the multiple header and tbody potential problems.

[TheNorthMemory]

  .use(require('markdown-it-multimd-table'));

try notation {headerless:true} like this can reproduced.

    .use(require('markdown-it-multimd-table'), { headerless: true });

[yiiman-dev]

@arve0 thanks for new update.
My problem is now fully resolved.