Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IPs to a region which has full scans running will re-add them #7

Open
tomekr opened this issue Oct 24, 2014 · 1 comment
Open

Comments

@tomekr
Copy link

tomekr commented Oct 24, 2014

Might have to implement a running status of some kind instead of just checking for

scan = self.where(has_full_scan: false).all

@aschmitz
Copy link
Owner

aschmitz commented Dec 1, 2014

This is a good point. Not sure how to do it, given that sometimes things "fall through the cracks" if they don't get re-queued in Sidekiq because a Tendril simply dropped off the network (rather than died in some other fashion), so we want to be able to handle that case as well. Perhaps flag it in the database, and then have a "clean up" button or something?

Unfortunately, I don't think Sidekiq has a way of checking up on jobs, but I should look in to that. If it does, we could just store the Sidekiq job ID, check if it was still running, and queue if it wasn't. That would be nice, if a bit resource-intensive if lots of jobs were running. (It's Redis, though, so it shouldn't be too bad.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants