Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawing text as functions instead of Surface members #12

Closed
dacap opened this issue Jul 25, 2019 · 0 comments
Closed

Drawing text as functions instead of Surface members #12

dacap opened this issue Jul 25, 2019 · 0 comments

Comments

@dacap
Copy link
Member

dacap commented Jul 25, 2019

To avoid always depending/linking with harfbuzz/icu libraries, we would prefer os::draw_text() as a global function instead of a os::Surface member function. Also we're going to use two alternatives:

  • os::draw_text(), and
  • os::draw_text_with_shaper()

To reduce binary size of apps that don't require the text shaping engine.
@dacap dacap mentioned this issue Jul 25, 2019
Open
18 tasks
dacap added a commit that referenced this issue Jul 29, 2019
@dacap
Move member function to draw text to global functions (fix #12)
2daa7b2 
In this way we can have a dependency with SkShaper dependency (which
is a pretty big dependency) in one compilation
unit (skia_draw_text_with_shaper()), so if a program doesn't use this
function (doesn't require SkShaper, harfbuzz, icu, etc.), then the
size of the final binary is reduced a lot.
@dacap dacap closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dacap