Fix bad d3.format metric setting and/or value === Infinity (apache#2399)

mistercrunch · web-flow · commit 08bdcd52b856 · 2017-03-14T12:18:51.000-07:00
diff --git a/superset/assets/javascripts/modules/utils.js b/superset/assets/javascripts/modules/utils.js
@@ -109,7 +109,11 @@ export function d3format(format, number) {
   if (!(format in formatters)) {
     formatters[format] = d3.format(format);
   }
-  return formatters[format](number);
+  try {
+    return formatters[format](number);
+  } catch (e) {
+    return 'ERR';
+  }
 }
 
 // Slice objects interact with their context through objects that implement

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,11 @@ export function d3format(format, number) {`
`109`	`109`	`if (!(format in formatters)) {`
`110`	`110`	`formatters[format] = d3.format(format);`
`111`	`111`	`}`
`112`		`- return formatters[format](number);`
	`112`	`+ try {`
	`113`	`+ return formatters[format](number);`
	`114`	`+ } catch (e) {`
	`115`	`+ return 'ERR';`
	`116`	`+ }`
`113`	`117`	`}`
`114`	`118`
`115`	`119`	`// Slice objects interact with their context through objects that implement`