Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to offset columns if layout is set to fluid #24

Closed
pcbulai opened this issue Jan 5, 2017 · 2 comments
Closed

Unable to offset columns if layout is set to fluid #24

pcbulai opened this issue Jan 5, 2017 · 2 comments

Comments

@pcbulai
Copy link

pcbulai commented Jan 5, 2017

https://github.com/atomicpages/skeleton-sass/blob/master/skeleton/core/_dependencies.scss#L28

I would much rather do &:first-child:not([class^="offset"]) { margin-left: 0; } instead, because offsetting a column is necessary regardless of the layout style( fluid or fixed ).
@atomicpages
Copy link
Owner

@pcbulai I agree.

atomicpages added a commit that referenced this issue Jan 9, 2017
@atomicpages
Addressing issue #24
37fc904
@atomicpages
Copy link
Owner

@pcbulai I finally got around to merging in your changes in the master branch. Thank you!

@dirkolbrich dirkolbrich mentioned this issue Apr 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcbulai @atomicpages