We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.colums
.container
when set to fixed grid and on small screen size ~320px width, .columnwill overflow .container due to standard padding at .containerin _grid.scss:8
.column
_grid.scss:8
/* BASE GRID * ------------------------------------------------ */ .container { position: relative; width: $base-width; max-width: $grid-max-width; margin: 0 auto; padding: 0 relative(20px); box-sizing: border-box; }
add max-widthto columns and delete small subtraction from widthof .colums in _mobileGrid(){}
max-width
width
_mobileGrid(){}
@mixin _mobileGrid($width, $colCount, $isFluid) { $width: if($isFluid, $mobile-fluid-width, $width); .container { width: $width; .column, .columns { max-width: 100%; // add max-width margin: { left: if($isFluid, 2%, 0); right: if($isFluid, 2%, 0); }; } @for $i from 1 through $colCount { @if ($i == 1) { .#{numToString($i)}.column { width: $width ; } } } @include _group($colCount, ".columns", "after") { width: $width; } // delete -4 .one-third.column { width: $width; } // delete -4 .two-thirds.column { width: $width; } // delete -4 .full-width.columns { width: $width; margin-left: 0; margin-right: 0; } @include _mobileOffset($colCount); } }
The text was updated successfully, but these errors were encountered:
@dirkolbrich same as issue #29, it will help me identify issues/see you fixes much faster!
Sorry, something went wrong.
I agree with this fix. Works wonderfully!
3.1.4
f6b3396
* Addressing issue #31 * Adding styles for `.one-half` * Adding new selectors to fixed grid: * `.one-third.columns` * `.two-third.columns` * `.one-half.column` * `.one-half.columns` * `.full-width.column` * Addressing issue #28 * Fixing configuration issues when `$base-gutter-width` is something other than `20px` in fixed grid mixin * Enforcing `body` margin styles to fixed overflow issue in `960px - 1129px` * Applies only to `fresh` theme
No branches or pull requests
when set to fixed grid and on small screen size ~320px width,
.column
will overflow.container
due to standard padding at.container
in_grid.scss:8
Proposed Fix
add
max-width
to columns and delete small subtraction fromwidth
of.colums
in_mobileGrid(){}
The text was updated successfully, but these errors were encountered: