Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming with button colors #34

Closed
e-compton opened this issue Nov 16, 2017 · 2 comments
Closed

Theming with button colors #34

e-compton opened this issue Nov 16, 2017 · 2 comments

Comments

@e-compton
Copy link

&:hover,
&:focus {
color: #333;
border-color: #888;
outline: 0;
}
&.button-primary {
color: #FFF;
background-color: #33C3F0;
border-color: #33C3F0;
&:hover,
&:focus {
color: #FFF;
background-color: #1EAEDB;
border-color: #1EAEDB;
}
}

Hi,

I was just creating a new project with skeleton and was hoping to customize the button colors, but I noticed that they're not exposed through variables.

Could these colors be moved to variables so that users have greater control over the colors of their buttons?

thanks

@atomicpages
Copy link
Owner

@e-compton I'll see if I can get to this change over the weekend. Feel free to fork if you made the change!

@e-compton
Copy link
Author

Sure I'll make the changes if you want. Should be able to get it done by the end of the day if you haven't already started.

e-compton pushed a commit to e-compton/skeleton-sass that referenced this issue Nov 19, 2017
atomicpages added a commit that referenced this issue Nov 20, 2017
Issue #34: Adding additional variables for button theming in fresh theme
atomicpages pushed a commit that referenced this issue Nov 20, 2017
* Addressing issue #34
* Merging #35 — thanks [e-compton](https://github.com/e-compton)!
* Adding more variables to `fresh` and `wing` themes
* Creating file on-the-fly for devs on gulp `sass` task
* Updating docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants