Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidyverse might have some deprecation that may impact some xportr functions #247

Closed
sadchla-codes opened this issue Feb 22, 2024 · 2 comments · Fixed by #250
Closed

Tidyverse might have some deprecation that may impact some xportr functions #247

sadchla-codes opened this issue Feb 22, 2024 · 2 comments · Fixed by #250

Comments

@sadchla-codes
Copy link
Collaborator

sadchla-codes commented Feb 22, 2024 •
edited
Loading

Screenshot 2024-02-21 at 10 46 18 PM

It's causing the 2 warnings when running tests from xportr::xportr_length()
Screenshot 2024-02-21 at 11 08 29 PM

Screenshot 2024-02-21 at 11 11 56 PM
@bms63
Copy link
Collaborator

bms63 commented Feb 23, 2024

Interesting this is just now showing up. @atorus-research/xportr-development-team anyone have some bandwidth to help knock this one out! I'm a bit full-up at the moment! 😭

@vedhav vedhav mentioned this issue Feb 24, 2024
Merged
@vedhav
Copy link
Collaborator

vedhav commented Feb 24, 2024

Looks like a quick fix. I just sent a small PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use selection helpers during variable based selection atorus-research/xportr
3 participants
@bms63 @vedhav @sadchla-codes