Skip to content

Commit abd6fb5

Browse files
committed
Merge branch 'master' of github.com:0xdata/h2o
2 parents c4a2750 + 2ff806a commit abd6fb5

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/main/java/hex/glm/GLM2.java

-1
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,6 @@ else if(glmt._beta[i] > 0)
336336
double [] newBeta = glmt._beta != null?glmt._beta.clone():MemoryManager.malloc8d(glmt._xy.length);
337337
double [] newBetaDeNorm = null;
338338
ADMMSolver slvr = new ADMMSolver(lambda[_lambdaIdx],alpha[0], _addedL2);
339-
slvr._n = glmt._n;
340339
slvr.solve(glmt._gram,glmt._xy,glmt._yy,newBeta);
341340
_addedL2 = slvr._addedL2;
342341
if(Utils.hasNaNsOrInfs(newBeta)){

src/main/java/hex/glm/LSMSolver.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ static final double[] shrink(double[] x, double[] z, double kappa) {
168168

169169

170170
public static final class ADMMSolver extends LSMSolver {
171-
public long _n;
172171
//public static final double DEFAULT_LAMBDA = 1e-5;
173172
public static final double DEFAULT_ALPHA = 0.5;
174173
public double _orlx = 1;//1.4; // over relaxation param
@@ -223,7 +222,7 @@ public boolean solve(Gram gram, double [] xy, double yy, double[] z, double objV
223222
final int N = xy.length;
224223
Arrays.fill(z, 0);
225224
if(_lambda>0 || _addedL2 > 0)
226-
gram.addDiag(_lambda*(1-_alpha)/_n + _addedL2);
225+
gram.addDiag(_lambda*(1-_alpha) + _addedL2);
227226
double rho = _rho;
228227
if(_alpha > 0 && _lambda > 0){
229228
if(Double.isNaN(_rho)) rho = _lambda*_alpha;//gram.diagMin()+1e-5;// find rho value as min diag element + constant

0 commit comments

Comments
 (0)