Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support the updated SageMaker Studio experience #51

Closed
ivan-khvostishkov opened this issue Jan 22, 2024 · 7 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ivan-khvostishkov
Copy link
Contributor

ivan-khvostishkov commented Jan 22, 2024

SageMaker SSH Helper works only in SageMaker Studio Classic:

As of November 30, 2023, the previous Amazon SageMaker Studio experience is now named Amazon SageMaker Studio Classic.

It needs testing and development for the new SageMaker Studio experience

UPD: Preliminary idea is to use custom images based on SageMaker distribution.

@ivan-khvostishkov
Copy link
Contributor Author

Related issue: #49

@zelenkastiot
Copy link

Hey @ivan-khvostishkov I saw the open PR #57 is this still under development?

Thanks

@nmartinbekier
Copy link

@ivan-khvostishkov , also wondering if PR#57 is intended to be merged eventually.
I've been using it for some months, but its a pity that in time it diverges more and more with master, and a hassle to have users in my organization to pull / checkout pr-57 instead of simply doing a pip install sagemaker-ssh-helper .
Thanks!

@NicolaiLolansen
Copy link

Would be nice on some more clarity on this, the readme of this repo could also do with a nice disclaimer that it only works for the old experience or Sagemaker Classic. Everywhere in the readme it says SageMaker Studio, and not classic.

@jakac
Copy link

jakac commented Feb 4, 2025

So the old Studio Classic is now deprecated. If I understand it correctly, that renders ssh'ing to notebooks using this tool deprecated as well. Would be great to either update the readme to make this clear or to add support for the new experience.

@ivan-khvostishkov ivan-khvostishkov self-assigned this Feb 27, 2025
@ivan-khvostishkov ivan-khvostishkov removed the help wanted Extra attention is needed label Feb 27, 2025
@ivan-khvostishkov
Copy link
Contributor Author

Will be fixed in the upcoming release.

@ivan-khvostishkov
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants