-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer require building kvssink to build samples #1159
base: develop-pre-3.4.1
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1159 +/- ##
===========================================
+ Coverage 16.48% 16.51% +0.03%
===========================================
Files 50 50
Lines 7019 7022 +3
===========================================
+ Hits 1157 1160 +3
Misses 5862 5862 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend not turning off building samples for these builds as we wouldn't know if something breaks with the samples. We can exclude samples for the codecov build though to improve our coverage reporting.
Remember to update ReadMe to reflect this |
What was changed?
BUILD_GSTREAMER_PLUGIN is no longer required to be ON for non-kvssink samples to be built. Added new flag BUILD_SAMPLES which defaults to ON to control the building of samples.
NOTE: GStreamer installation is still required for all samples.
Why was it changed?
To allow for the building of non-kvssink samples without the need for building kvssink.
How was it changed?
By removing the sample targets from the BUILD_GSTREAMER_PLUGIN conditional and adding the to a BUILD_SAMPLES conditional.
What testing was done for the changes?
The CI will pass, and testing will be done locally on Mac.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.