Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completions #29

Closed
azdavis opened this issue Mar 29, 2023 · 2 comments
Closed

Add completions #29

azdavis opened this issue Mar 29, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@azdavis
Copy link
Owner

azdavis commented Mar 29, 2023 •
edited
Loading

Problem

Millet doesn't offer completions, e.g. when typing val x = List. it'd be nice to mention all the things from the List structure, or even just when typing val x = S we could show String, etc as suggestions.

Solution

Implement completions in the LSP spec.
@azdavis azdavis added the enhancement New feature or request label Mar 29, 2023
@azdavis
Copy link
Owner Author

azdavis commented Mar 29, 2023

Already somewhat implemented: https://github.com/azdavis/millet/blob/4e0bed39cdb0e858cbbf84248537bdd3a01dabcc/crates/analysis/src/lib.rs/#L273-L278

@azdavis
Copy link
Owner Author

azdavis commented Jun 16, 2023

Done in v0.11.0

@azdavis azdavis closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azdavis