Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen values before posting through the API #2

Open
dishonesthips opened this issue May 3, 2019 · 0 comments
Open

Screen values before posting through the API #2

dishonesthips opened this issue May 3, 2019 · 0 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@dishonesthips
Copy link
Contributor

dishonesthips commented May 3, 2019

Currently, SlackDB doesn't guard against its users fucking themselves over by posting values that match the key schema. Unlike when regular users do this through their Slack client, values posted through SlackDB will appear under the name of the bot user. As a result, when SlackDB searches for a key with the only_bot? flag set, it will confuse itself into thinking a thread value is actually a key (if it matches the schema).

We should screen all values passed into the functions create\6, update\4, and append\4 and return an error if any element of the list matches the key schema (specified by the regex attribute @key_schema)

@dishonesthips dishonesthips added the good first issue Good for newcomers label May 3, 2019
@dishonesthips dishonesthips added this to the v0.2 milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant