Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EBNFRecursiveDescentSyntaxParser.Parse(IList, Rule, int, string) #50

Closed
b3b00 opened this issue Feb 9, 2018 · 0 comments
Closed
Assignees

Comments

@b3b00
Copy link
Owner

b3b00 commented Feb 9, 2018

I've selected EBNFRecursiveDescentSyntaxParser.Parse(IList, Rule, int, string) for refactoring, which is a unit of 103 lines of code and 23 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Limit the number of branch points (if, for, while, etc.) per unit to 4.
  • Why
    Keeping the number of branch points low makes units easier to modify and test.
  • How 🔧
    Split complex units with a high number of branch points into smaller and simpler ones.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

@b3b00 b3b00 self-assigned this Feb 9, 2018
b3b00 added a commit that referenced this issue Feb 12, 2018
@b3b00 b3b00 closed this as completed in 21735e5 Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant