Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button styling issue in Nova v4.29 #58

Closed
ValCanBuild opened this issue Nov 10, 2023 · 3 comments · Fixed by #59
Closed

Save button styling issue in Nova v4.29 #58

ValCanBuild opened this issue Nov 10, 2023 · 3 comments · Fixed by #59
Labels
bug Something isn't working

Comments

@ValCanBuild
Copy link

ValCanBuild commented Nov 10, 2023

CleanShot 2023-11-10 at 14 16 32

The save button doesn't seem to be getting style appropriately on the latest nova version. I'm on 4.29.5 as you can see in the screenshot

@bakerkretzmar bakerkretzmar added the bug Something isn't working label Nov 10, 2023
@bakerkretzmar
Copy link
Owner

I don't have an up-to-date Nova 4 license so I can't test this, but if you can PR a fix that would be awesome, or if you're able to figure out what style change caused it I can try to fix it.

@vbezruchkin
Copy link

hi @bakerkretzmar thanks for your work.

Here is the relevant commit from the similar package:

https://github.com/outl1ne/nova-settings/pull/175/files

Thanks in advance!

@vbezruchkin
Copy link

Hi,

Just a quick follow-up. Here is a similar fix also:

stepanenko3/nova-command-runner@v4.2.5...v4.2.6

They also had the wrong buttons. No pressure from me, I just wanted to point in the correct direction.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants