Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opera and Edge support #13

Closed
basshelal opened this issue Sep 7, 2019 · 2 comments
Closed

Add Opera and Edge support #13

basshelal opened this issue Sep 7, 2019 · 2 comments
Assignees
Labels
Marketing Non technical marketing stuff New feature New feature or request

Comments

@basshelal
Copy link
Owner

Opera uses a similar extensions API to Chrome so it should be pretty straightforward. However Opera does not support chrome.storange.sync according to their website so we'll have to use chrome.storage.local instead.

This is only useful in that we can say we support 3 browsers instead of 2, the number of users that this will add is negligible. Basically it's nice marketing and who knows maybe those 4 guys who use Opera as their daily browser might be grateful.

@basshelal basshelal added the Marketing Non technical marketing stuff label Sep 7, 2019
@basshelal basshelal self-assigned this Sep 7, 2019
@basshelal basshelal changed the title Add Opera support Add Opera and Edge support Sep 7, 2019
@basshelal
Copy link
Owner Author

We can also probably add Edge support as well since they claim to have an easy transition and use a similar API.

@basshelal basshelal added the New feature New feature or request label Sep 11, 2019
@basshelal
Copy link
Owner Author

Wudooh now fully works on Chrome, Edge (Chromium), Opera and Chromium.
Behavior is identical across browsers!
Only sync functionality is slightly different between browsers but the beauty of Chromium means that if there is no chrome.storage.sync then chrome.storage.local is always used instead. This is the case in Opera, basic Chromium and when the user is not signed in to their Google or Microsoft (Edge only) account. In all other cases though, we get the local storage implementation for free.
Nice 😁
I'm still testing this extensively on all 4 Chromium browsers, but unless something drastic comes up I'd say this is done!
Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Marketing Non technical marketing stuff New feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant