-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use automated analytics test in tvos CI pipelines #16
Comments
@andreasgangso This is not just adding a line to GH actions, as I need to modify the UI test to send analytics to Rudderstack for the analytics test to succeed |
It should send analytics already, since its logging in etc.
If not then thats the real problem i guess
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Sigve Hansen ***@***.***>
Sent: Monday, September 9, 2024 12:13:26 PM
To: bcc-code/bcc-media-tvos ***@***.***>
Cc: Andreas Gangsø ***@***.***>; Mention ***@***.***>
Subject: Re: [bcc-code/bcc-media-tvos] Use automated analytics test in tvos CI pipelines (Issue #16)
@andreasgangso<https://github.com/andreasgangso> This is not just adding a line to GH actions, as I need to modify the UI test to send analytics to Rudderstack for the analytics test to succeed
—
Reply to this email directly, view it on GitHub<#16 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFRQVISYWWEN2JXTXPMWU3ZVVYENAVCNFSM6AAAAABM2NDR3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZXG4YDENBWHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@andreasgangso We didn't pass in the Rudderstack write key and dataplane URL env vars in the workflow file 😅 |
@kkuepper Andreas thinks we should just drop this task, as he doesn't think it is worth the time. What do you think? |
Matjaz and I concluded with dropping this task, as there is too much work for too little gain. |
Didn't we decide that already in the Daily Scrum? |
@kkuepper Correct, my bad 👍 |
Ref bcc-code/bcc-media-platform#863
I guess just add a line to GH actions but dont have time rn
The text was updated successfully, but these errors were encountered: