Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITIGNORE_MAINTAINERCLEANFILES_M4_LIBTOOL ignores AC_CONFIG_MACRO_DIRS #36

Open
Bob131 opened this issue Aug 30, 2016 · 5 comments
Open

Comments

@Bob131
Copy link

Bob131 commented Aug 30, 2016

It took me a while to work out what was happening, until I noticed I had an extra 'S' on my macro invocation :)

Apparently either is equally valid. I thought maybe the 'S' variant had been deprecated or something, but it's the one recommended by the automake manual: https://www.gnu.org/software/automake/manual/html_node/Local-Macros.html

@behdad
Copy link
Owner

behdad commented Aug 30, 2016

Thanks. Got Pull-Request?

@Bob131
Copy link
Author

Bob131 commented Aug 30, 2016

Sorry, no. My automake-fu isn't really up to it.

On Tue, Aug 30, 2016 at 12:20 PM, Behdad Esfahbod
[email protected] wrote:

Thanks. Got Pull-Request?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@behdad
Copy link
Owner

behdad commented Aug 30, 2016

No worries

@behdad
Copy link
Owner

behdad commented Sep 2, 2016

Ok. I'm also very distant from that world these days. Let's keep open for now. Thanks.

@mcatanzaro
Copy link
Contributor

Same for AC_CONFIG_MACRO_DIR.

There is a trick: the directory specified in AC_CONFIG_MACRO_DIR and the directories specified by AC_CONFIG_MACRO_DIRS should really be ignored if and only if there are not any non-ignored files in the directory already. It's totally legitimate to put macros in there under version control, but if you don't have any then you really do want the directory to go in the .gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants