Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu for tab #13

Open
danil-tolkachev opened this issue Dec 17, 2020 · 4 comments
Open

Context menu for tab #13

danil-tolkachev opened this issue Dec 17, 2020 · 4 comments
Labels
wontfix This will not be worked on

Comments

@danil-tolkachev
Copy link

It would be great if the context menu showed by right click on tab.

image

@benji300
Copy link
Owner

This is an interesting idea. Unfortunately, it is probably not technically feasible at the moment. There are essentially two problems.

  1. I can't reuse the note list context menu. That means I would have to implement it by myself. I would even have to reimplement some of the functionalities, because they are not available as commands. That would be quite a lot of work.

  2. The second problem (the bigger one) is that the context menu is locked within the panel. That means it cannot be displayed outside the boundaries of the panel. I've also tested with "z-index" in the CSS. The following screenshots show what I mean. The menu just disappears "under" the editor.

image

image

The code can be found in test branch: https://github.com/benji300/joplin-note-tabs/tree/context-menu

@benji300 benji300 added the wontfix This will not be worked on label Jan 8, 2021
@ajay-gh
Copy link

ajay-gh commented May 13, 2021

In order to use space in the Joplin window efficiently, it seem important to me to turn tabs visibility on and off in the course of using Joplin. Right now this requires three precision point-and-click s with the mouse (in the tools menu). I would really appreciate a keyboard shortcut, and if this was not possible, that the toggle visibility switch was move up to the main tools menu.

@benji300
Copy link
Owner

I don't know what this has to do with the context menu but well...

You can assign a keyboard shortcut to the tabsToggleVisibility command. You can do that easily in the keyboard shortcuts editor. If the command is not listed, please ask the developer, why still not all plugin commands are listed.
As a workaround you can also define the keyboard shortcut directly in keymap-desktop.json. How to do this has already been described in the forum.

The second possibility would be to call the command via the command palette. This way you could execute the command without interaction with the mouse.

@ajay-gh
Copy link

ajay-gh commented May 13, 2021

Thanks for the hints. I simply didn't realize how easy it was to add command/shortcuts not (yet) listed in the Joplin shortcuts editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants