remove inputs from action.yml since they are all env vars now #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmatselby
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Thank you for this @tastapod. I wonder if things have changed since I originally built this. It kinda "just works" all the time, so I don't spend that much time looking at this.
I've re-read the docs and this change seems to make sense :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this input stanza in
action.ymldoes not have any impact on the build, it causes warnings in VS Code because it specifies a few mandatory values that are now provided as environment variables.Fixes #57