Show Wrangler output from deploy command when verbose=true

Author: benvinegar

packages/cli/src/__tests__/cloudflare.test.ts

@@ -178,27 +178,23 @@ describe("CloudflareClient", () => {
     describe("deploy", () => {
         it("should extract worker URL from deploy output", async () => {
             vi.mocked($).mockImplementation(() => {
-                return {
-                    stdout: "Worker deployed to test-worker.test-account.workers.dev",
-                    stderr: "",
-                    exitCode: 0,
+                return async function* () {
+                    yield "Worker deployed to test-worker.test-account.workers.dev";
                 };
             });
 
-            const result = await client.deploy();
+            const result = await client.deploy(false);
             expect(result).toBe("https://test-worker.test-account.workers.dev");
         });
 
         it("should return <unknown> if URL not found in output", async () => {
             vi.mocked($).mockImplementation(() => {
-                return {
-                    stdout: "Deployment successful but no URL found",
-                    stderr: "",
-                    exitCode: 0,
+                return async function* () {
+                    yield "Deployment successful but no URL found";
                 };
             });
 
-            const result = await client.deploy();
+            const result = await client.deploy(false);
             expect(result).toBe("<unknown>");
         });
 
@@ -207,7 +203,9 @@ describe("CloudflareClient", () => {
                 throw new Error("Deployment failed");
             });
 
-            await expect(client.deploy()).rejects.toThrow("Deployment failed");
+            await expect(client.deploy(false)).rejects.toThrow(
+                "Deployment failed",
+            );
         });
     });
 });

packages/cli/src/cloudflare.ts

@@ -77,13 +77,21 @@ export class CloudflareClient {
         return true;
     }
 
-    async deploy(): Promise<string> {
+    async deploy(verbose: boolean): Promise<string> {
         try {
-            const result = await $({
+            const p = $({
                 quiet: true,
             })`npx wrangler deploy --config ${this.configPath}`;
 
-            const match = result.stdout.match(
+            let output = "";
+            for await (const text of p) {
+                output += text;
+                if (verbose) {
+                    console.log(text);
+                }
+            }
+
+            const match = output.match(
                 /([a-z0-9-]+\.[a-z0-9-]+\.workers\.dev)/i,
             );
             return match ? "https://" + match[0] : "<unknown>";

packages/cli/src/install.ts

@@ -256,18 +256,27 @@ Your token needs these permissions:
     const promise = new Promise<void>(async (resolve, reject) => {
         if (await promptDeploy(serverPkgJson.version)) {
             let deployUrl;
+
             let s = spinner();
-            s.start(`Deploying CounterScale ...`);
+            s.start(`Deploying Counterscale ...`);
 
             try {
-                deployUrl = await cloudflare.deploy();
+                if (opts.verbose) {
+                    s.stop(`Deploying Counterscale ...`);
+                }
+
+                deployUrl = await cloudflare.deploy(
+                    opts.verbose ? true : false,
+                );
+
+                if (!opts.verbose) {
+                    s.stop("Deploying Counterscale ... Done.");
+                }
             } catch (err) {
-                s.stop("Deploying CounterScale ... Failed!", 1);
+                s.stop("Deploying Counterscale ... Failed!", 1);
                 return reject(err);
             }
 
-            s.stop("Deploying CounterScale ... Done.");
-
             if (deployUrl) {
                 await tick(() =>
                     note(