Skip to content

Commit d333ba6

Browse files
authored
docs: update readme and add contributing file (#30)
* docs: update readme and add contributing file * docs(readme): add contributing section * chore: remove github semantic app
1 parent b448fa9 commit d333ba6

File tree

5 files changed

+154
-803
lines changed

5 files changed

+154
-803
lines changed

.github/semantic.yml

-9
This file was deleted.

CONTRIBUTING.md

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Contributing
2+
3+
1. **Fork** the repo on GitHub
4+
2. **Clone** the project to your own machine
5+
3. **Commit** changes to your own branch
6+
4. **Push** your work back up to your fork
7+
5. Submit a **Pull request** so that we can review your changes
8+
9+
> Be sure to merge the latest from "upstream" before making a pull request!
10+
11+
## How to run the project locally on your machine?
12+
13+
1. Install dependencies in root folder, src folder and demo folder with `npm install` on each folder.
14+
2. Start an Android emulator or iOS simulator.
15+
3. From root folder, run `npm run dev` in a terminal tab.
16+
4. From root folder, run `npm run debug:android -- --path demo` (or `npm run debug:ios -- --path demo`) in another terminal tab.
17+
18+
> You have to be careful with the update of dependencies, this can cause a certain number of errors, especially related to TypeScript.

README.md

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# NativeScript Getters Plugin
22

33
![NPM version](https://img.shields.io/npm/v/nativescript-getters)
4-
![GitHub last commit](https://img.shields.io/github/last-commit/bgrand-ch/nativescript-getters)
5-
![NPM downloads](https://img.shields.io/npm/dw/nativescript-getters)
64
![NPM bundle size](https://img.shields.io/bundlephobia/min/nativescript-getters)
5+
![NPM total downloads](https://img.shields.io/npm/dt/nativescript-getters)
6+
![GitHub last commit](https://img.shields.io/github/last-commit/bgrand-ch/nativescript-getters)
77

88
A NativeScript plugin that adds six new getters – in addition to the native `getViewById` method – to retrieve one or more views by tag, type, class, property, value pair or style.
99

@@ -123,8 +123,6 @@ export function navigatingTo(args: EventData) {
123123

124124
The list of possible property names can be found on the [view page](https://v7.docs.nativescript.org/api-reference/classes/view.html) of the NativeScript API documentation.
125125

126-
> Note: The color name (example: red or white) is converted by NativeScript to hexadecimal.
127-
128126
#### Get views by val pairs
129127

130128
```typescript
@@ -163,6 +161,8 @@ export function navigatingTo(args: EventData) {
163161
}
164162
```
165163

164+
> Note: The color name (example: red or white) is converted by NativeScript to hexadecimal.
165+
166166
The list of possible styles can be found on the [style page](https://v7.docs.nativescript.org/api-reference/classes/style.html) of the NativeScript API documentation.
167167

168168
### Example in stand-alone mode
@@ -239,6 +239,10 @@ If you have a question about how `nativescript-getters` works or an idea to impr
239239

240240
However, if you get an error, you should open an [issue](https://github.com/bgrand-ch/nativescript-getters/issues).
241241

242+
## Contributing
243+
244+
See [CONTRIBUTING](https://github.com/bgrand-ch/nativescript-getters/blob/main/CONTRIBUTING.md) for more information.
245+
242246
## License
243247

244248
Distributed under the MIT License. See [LICENSE](https://github.com/bgrand-ch/nativescript-getters/blob/main/LICENSE.md) for more information.

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
},
1717
"devDependencies": {
1818
"@nativescript/eslint-plugin": "0.0.4",
19-
"commitizen": "4.2.4",
19+
"commitizen": "4.2.5",
2020
"cz-conventional-changelog": "3.3.0",
2121
"eslint": "7.26.0",
22-
"nativescript": "8.0.1",
23-
"standard-version": "9.3.0"
22+
"nativescript": "8.3.3",
23+
"standard-version": "9.5.0"
2424
}
2525
}

0 commit comments

Comments
 (0)