Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for a column called "probe" in "annot" for "molecular.subtyping" and "intrinsic.cluster.predict" but not "oncotypedx" and "gene70" #15

Open
PedroMilanezAlmeida opened this issue Sep 23, 2019 · 3 comments
Assignees
Labels

Comments

@PedroMilanezAlmeida
Copy link

Hey y'all,

It would be great if the help of "molecular.subtyping" and "intrinsic.cluster.predict" would indicate the need for a column called "probe" in "annot".

Right now it says only that at least one column named "EntrezGene.ID" (for ssp, scm, AIMS, and claudinLow models) or "Gene.Symbol" (for the intClust model) is needed, but a column called "probe" is also needed.

This is problematic because other functions such as "oncotypedx" and "gene70" require the rownames of "annot" to be the probe names, instead of a column called "probe" with the probe names.

It would be even better if this was unified (e.g., either "annot" always needs a "probe" column or it never does).

Cheers and thanks!

@Puriney
Copy link

Puriney commented Jun 4, 2020

Yes. The first column of the annot should be "probe", which should be as same as the col names of the data, otherwise error shows up:

Error in dimnames(x) <- dn :
length of 'dimnames' [1] not equal to array extent

@ChristopherEeles
Copy link
Contributor

Hi @Puriney,

I will address this issue in the next update. It will likely take a few weeks though, as I am currently occupied with other projects.

Best,
Christopher Eeles
Software Developer
Benjamin Haibe-Kains Lab
Princess Margaret Cancer Centre

@Puriney
Copy link

Puriney commented Jun 5, 2020

No worry. The quick solution exists. We end-users can simply add one column named 'probe' and then the problem is solved. This issue, I guess, is to simply remind you to correct the description in the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants