Remove unnecessary null check in conjunction with instanceof

liugddx · kun-song · commit d54633edf0c3 · 2019-04-29T23:35:46.000+08:00
diff --git a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/DecodeHandler.java b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/DecodeHandler.java
@@ -52,7 +52,7 @@ public void received(Channel channel, Object message) throws RemotingException {
     }
 
     private void decode(Object message) {
-        if (message != null && message instanceof Decodeable) {
+        if (message instanceof Decodeable) {
             try {
                 ((Decodeable) message).decode();
                 if (log.isDebugEnabled()) {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public void received(Channel channel, Object message) throws RemotingException {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`private void decode(Object message) {`
`55`		`- if (message != null && message instanceof Decodeable) {`
	`55`	`+ if (message instanceof Decodeable) {`
`56`	`56`	`try {`
`57`	`57`	`((Decodeable) message).decode();`
`58`	`58`	`if (log.isDebugEnabled()) {`