Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in general_shared_ft Calculation #12

Closed
Ho-Garfield opened this issue Sep 13, 2024 · 2 comments
Closed

Discrepancy in general_shared_ft Calculation #12

Ho-Garfield opened this issue Sep 13, 2024 · 2 comments

Comments

@Ho-Garfield
Copy link

Hi,we noticed a discrepancy between the calculation of general_shared_ft in the code and the method described in the original paper.

general_shared_ft = shared_ft[mode_split[0]:N * C + 1:C]  # take the 1st available mode for shared fts
# general_shared_ft = 0  # average available shared fts
# for m in mode_split: general_shared_ft += shared_ft[m:N * C + 1:C]
# general_shared_ft /= len(mode_split)

image
The approach in the original paper seems more aligned with the commented-out code block. Could you please advise on which one we should use?

@billhhh
Copy link
Owner

billhhh commented Sep 22, 2024

Hello, thank you for your question and interested in our work.
In short, both would work, the current uncommented one is used for simplicity.

Similar question can be referred to #4

@billhhh billhhh closed this as completed Sep 23, 2024
@billhhh
Copy link
Owner

billhhh commented Sep 23, 2024

Close the issue for now, if you have more questions, feel free to ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants