Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DnsRecordResolverTest: testBestSRVRecord_MultipleRecords_Priority_Same not 100% deterministic (but should be) #1300

Closed
Tracked by #1286
rfc2822 opened this issue Feb 6, 2025 · 0 comments · Fixed by #1306
Closed
Tracked by #1286

DnsRecordResolverTest: testBestSRVRecord_MultipleRecords_Priority_Same not 100% deterministic (but should be) #1300

rfc2822 opened this issue Feb 6, 2025 · 0 comments · Fixed by #1306
Assignees
@sunkup
Labels
bug Something isn't working

Comments

@rfc2822
Copy link
Member

rfc2822 commented Feb 6, 2025 •
edited
Loading

Idea: maybe provide random number generator as argument / mockable method? Then we can provide a deterministic mock for tests.
@rfc2822 rfc2822 mentioned this issue Feb 6, 2025
Open
5 tasks
@rfc2822 rfc2822 added the bug Something isn't working label Feb 6, 2025
@sunkup sunkup linked a pull request Feb 11, 2025 that will close this issue
DnsRecordResolverTest: Use seeded random number generator for deterministic test result #1306
Merged
4 tasks
@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Feb 11, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunkup sunkup

Labels
bug Something isn't working
Projects
DAVx⁵ Releases
Status: Done
Milestone
No milestone
2 participants
@rfc2822 @sunkup