You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the relocation is performed using relok8s, the readme file change is not performed. Maybe this step should be decoupled from the relocation backend used.
I am considering this a regression since in the project documentation we state that readme file changes will be performed.
It's tricky, some additional metadata will be required to be translated next to the relok8s local bundles. This piece of metadata will contain the repoName that will be used in the readme rewrites. Would that make sense?
I would have to take a look at the big picture first. Can you describe which is the charts-syncer -> relok8s behavior? What is modifying the values.yaml files and so on in that case? It feels like the README.md is out of the scope of relok8s but maybe there is no other place to perform additional pre-processing before packaging the charts again.
If the relocation is performed using relok8s, the readme file change is not performed. Maybe this step should be decoupled from the relocation backend used.
I am considering this a regression since in the project documentation we state that readme file changes will be performed.
cc/ @tompizmor @jotadrilo
The text was updated successfully, but these errors were encountered: